Enable /WX for msvc + Fix the various new warnings that appear for x64 compilation#2118
Closed
Kenzzer wants to merge 9 commits intoalliedmodders:masterfrom
Closed
Enable /WX for msvc + Fix the various new warnings that appear for x64 compilation#2118Kenzzer wants to merge 9 commits intoalliedmodders:masterfrom
Kenzzer wants to merge 9 commits intoalliedmodders:masterfrom
Conversation
Member
Author
|
Will re-make this PR eventually, but this time to fix warnings into smaller batches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at bringing consistent compilation flags between linux and windows. Namely the use of
-Werrorequivalent/WXfor msvc. When enabled, this will make sourcemod fail compilation for 64 bits (it compiles fine but with warnings otherwise). And I don't think we should ignore those warnings, especially if those locations involve code that's about messing with memory and pointers. Putting that aside, there are so many warnings that this clutter the console and makes it really annoying to develop anything, and while we could decrease the warning level or outright silence them like on linux with something similar to-Wno-narrowing, I don't think we should enable that behaviour any longer since those can be very useful warnings when compiling for two different targets.PR is marked as draft until alliedmodders/amtl#128 & alliedmodders/sourcepawn#950 have landed, otherwise the github CI will fail. (I've currently updated the submodules to target my repo so the CI doesn't fail, this will be reverted)